Skip to content

MENDELU/Edit citace by message#1264

Merged
milanmajchrak merged 2 commits intocustomer/mendelufrom
mendelu/edit-citace-by-message
Mar 25, 2026
Merged

MENDELU/Edit citace by message#1264
milanmajchrak merged 2 commits intocustomer/mendelufrom
mendelu/edit-citace-by-message

Conversation

@Kasinhou
Copy link
Copy Markdown

@Kasinhou Kasinhou commented Mar 24, 2026

Problem description

Issue: https://github.com/dataquest-dev/dspace-customers/issues/508

Sync verification

If en.json5 or cs.json5 translation files were updated:

  • Run yarn run sync-i18n -t src/assets/i18n/cs.json5 -i to synchronize messages, and changes are included in this PR.

Manual Testing (if applicable)

Copilot review

  • Requested review from Copilot

@Kasinhou Kasinhou self-assigned this Mar 24, 2026
@Kasinhou Kasinhou requested a review from milanmajchrak March 24, 2026 12:08
@milanmajchrak milanmajchrak requested a review from Copilot March 25, 2026 13:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a localized disclaimer message for Citace Pro-generated citations and ensures the citation field component can render translations in its standalone template.

Changes:

  • Added new i18n key item.page.citace-pro.disclaimer to en.json5 and cs.json5.
  • Updated the citation field standalone component to import TranslateModule.
  • Rendered the disclaimer under the Citace Pro iframe in the citation component template.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/assets/i18n/en.json5 Adds English disclaimer string for Citace Pro citations.
src/assets/i18n/cs.json5 Adds Czech disclaimer string (with the repo’s “English comment” line).
src/app/item-page/simple/field-components/specific-field/citation/item-page-citation.component.ts Imports TranslateModule so the template’s translate pipe works in a standalone component.
src/app/item-page/simple/field-components/specific-field/citation/item-page-citation.component.html Displays the new translated disclaimer beneath the Citace Pro iframe.

@milanmajchrak milanmajchrak merged commit 4a16012 into customer/mendelu Mar 25, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants